Workaround #2335 issue in bootstraped REPL #2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
May 1, 2017
| @@ -15,12 +15,20 @@ case class TermState( | |||
| ) extends TermAction | |||
|
|
|||
| object TermState { | |||
| // Using unapply instead exposes a dotty/scalac variation. Because TermState | |||
| // is case class, scalac generate an unapply with this exact signature, that | |||
smarter
reviewed
May 1, 2017
| @@ -15,12 +15,20 @@ case class TermState( | |||
| ) extends TermAction | |||
|
|
|||
| object TermState { | |||
| // Using unapply instead exposes a dotty/scalac variation. Because TermState | |||
| // is case class, scalac generate an unapply with this exact signature, that | |||
| // is used by the TermInfo | TermAction unapplies. With dotty, the generated | |||
There was a problem hiding this comment.
I would say TermInfo and TermAction instead of TermInfo | TermAction to avoid confusion with union types here.
smarter
approved these changes
May 1, 2017
OlivierBlanvillain
force-pushed
the
workaround-#2335
branch
from
9cb21f2 to
3c26292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.